This repository was archived by the owner on Aug 30, 2024. It is now read-only.
BUILD: add _distributor_init.py to preload dll on windows #50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes #49 |
rgommers
reviewed
Jun 15, 2019
|
It seemed easier to just copy-paste the code from numpy. I also intend to extend this to handle all the OpenBlas setup (download, unzip, set up so numpy can find it) in one place rather than in each CI yaml file. This can be then reused by the numpy CI, see numpy/numpy#13772 |
|
Okay thanks @mattip. You're doing the work, so let's go with your preference:) |
This was referenced Jun 16, 2019
rgommers
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the fix for numpy/numpy#13764, the other part (removing code from
numpy/core/__init__.pyand duplicating this code there) has to be done in the numpy repo after this is merged in order to reuseopenblas_support.pyfrom here.This creates a
_distributor_local.pyfile which is packaged with the wheel (on windows only).I named the new file
openblas_support.pyin the hope that we can add some of the environment variables to it which might unify some of the travis/appveyor/future azure/ CI behaviour